Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong observation metadata in timeseries #238

Closed
wholmgren opened this issue Nov 5, 2019 · 0 comments · Fixed by #239
Closed

wrong observation metadata in timeseries #238

wholmgren opened this issue Nov 5, 2019 · 0 comments · Fixed by #239
Labels
reports Issue pertains to reporting
Milestone

Comments

@wholmgren
Copy link
Member

wholmgren commented Nov 5, 2019

reports.figures.timeseries contains logic to shade the observation time series according to its interval_length and logic to control the step based on interval_label. The problem is that the function gets the original observation instead of processed observation metadata.

report.render_raw_report creates fx_obs_cds, a list of tuples (RawReport.processed_forecasts_observations.original, ColumnDataSource).

Probably need to change that to be the ProcessedForecastObservation elements RawReport.processed_forecasts_observations object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reports Issue pertains to reporting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant