Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests #4

Open
solarchemist opened this issue Feb 2, 2023 · 1 comment
Open

Add unit tests #4

solarchemist opened this issue Feb 2, 2023 · 1 comment
Assignees
@solarchemist

Comments

@solarchemist
Copy link
Owner

This being our most mature R package, perhaps it is a good candidate for introducing unit tests.

The "R packages" book is a good place to start
https://r-pkgs.org/testing-basics.html
@solarchemist solarchemist self-assigned this Feb 2, 2023
@solarchemist
Copy link
Owner Author

I think this package could benefit a lot from unit tests.
Be explicit about the kinds of UV-Vis spectra that this algorithm has been tested to work for.
A noisy spectrum, an obscured band edge, the different kinds of transitions, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@solarchemist solarchemist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solarchemist