Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FacetSet::build incompatible with parent build function #65

Closed
PorridgeBear opened this issue Jan 18, 2012 · 4 comments
Closed

FacetSet::build incompatible with parent build function #65

PorridgeBear opened this issue Jan 18, 2012 · 4 comments

Comments

@PorridgeBear
Copy link

Hey

I am seeing the following issue after updating Solarium from git today:

Runtime Notice: Declaration of Solarium_Client_RequestBuilder_Select_Component_FacetSet::build() should be compatible with that of Solarium_Client_RequestBuilder::build() in /Users/Punk/Sites/github/Sought/Symfony/vendor/solarium/library/Solarium/Client/RequestBuilder/Select/Component/FacetSet.php line 0

As far as I can tell the FacetSet::build takes a second arg $request, but the parent RequestBuilder::build does not.

Is this a regression?

Cheers

@PorridgeBear
Copy link
Author

Hm, it seems my project, despite pulling from https://github.com/basdenooijer/solarium.git is getting the nextgen/feature branch.

@basdenooijer
Copy link
Member

Ok, the feature/nextgen branch isn't stable yet, but I'll fix this one asap.

@basdenooijer
Copy link
Member

I couldn't reproduce this in the feature/nextgen branch. Looking at the non-namespaced classnames in your error I think you might be using the develop branch. This branch did have an issue. I've added a fix.

@PorridgeBear
Copy link
Author

Thanks I was on the wrong branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants