Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[TASK] Implement core admin api for solarium #625
By now it is backwards compatible and i tried to implement it in a way that it fit's into the current structure of solarium. It would be nice to get your Feedback.
There are something where it would be good that we discuss them:
What do you think? By now everything is implemented to keep backwards compatibility but it might makes sence to introduce so breaking changes in version 5.
And for sure some examples and documentation is missing but i would add after we agree on a way how the implementation should be done.
First of all, great work so far!
I'm interested in getting this in very quickly.
In which way will this cause breaking changes?
Even the name getCoreBaseUri() is wrong in the context of Solr Cloud collections.
For sure, the documentation needs to be enhanced for getBaseUri().
@mkalkbrenner thanks for your feedback:
Because we would have two new packages below QueryType e.g. Server (for the server related querys like the admin query) and Core (for the core specific query, everything else then the CoreAdmin queries by now). I am not happy with these names by now but i would say we would need one package for server specific queries and one for the core/collection specific query. Or we keep the queries as they are and just add a new package for the Server specific.
Do you have a proposal there?
Having getCoreBaseUri and getServerUri is good. With removing the "isCoreIndependet" stuff, do you mean just to remove the boolean value here? Because on the query/request level we need to have this information to be able to decide if "getCoreBaseUri" or "getServerUri" needs to be called.
As i understand you right i would:
Is that right? Do you have other proposals?
That's the backward compatible way I would prefer.
getCoreBaseUri and getServerUri will be new functions.