Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust example 1.1 using composer #659

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@clemens-tolboom
Copy link

clemens-tolboom commented Mar 26, 2019

Following comment in #323 (comment)

I also assume running from the command line as that clean up the example more. Hope that's fine too.

Adjust example using composer
Following comment in #323 (comment)

I also assume running from the command line as that clean up the example more. Hope that's fine too.

@clemens-tolboom clemens-tolboom changed the title Adjust example using composer Adjust example 1.1 using composer Mar 26, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 26, 2019

Coverage Status

Coverage remained the same at 92.4% when pulling 5935c52 on clemens-tolboom:patch-1 into 5d4ee73 on solariumphp:master.

@@ -1,10 +1,11 @@
<?php
require(__DIR__.'/init.php');
htmlHeader();
require(__DIR__ . '/vendor/autoload.php');

This comment has been minimized.

Copy link
@clemens-tolboom

clemens-tolboom Mar 26, 2019

Author

As this is an example maybe better not use __DIR__ but

require('./vendor/autoload.php');

then people can copy/paste and maybe run immediately.

clemens-tolboom added a commit to clemens-tolboom/solarium that referenced this pull request Mar 26, 2019

Update 1.2-basic-select using composer
Similar to solariumphp#659:

- assume command line so no HTML
- use current directory (which works better for converting other examples using symlinks)
@clemens-tolboom

This comment has been minimized.

Copy link
Author

clemens-tolboom commented Mar 26, 2019

Hmmm ... guess I'm wrong in 'No HTML' as 1.3 is harder to convert. Guess it's better to close this and start over making a new PR. Similar for #660.

Keeping this open until feedback.

@clemens-tolboom

This comment has been minimized.

Copy link
Author

clemens-tolboom commented Mar 27, 2019

This was a bad call

@clemens-tolboom clemens-tolboom deleted the clemens-tolboom:patch-1 branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.