Skip to content
This repository has been archived by the owner. It is now read-only.

Duplicate menus after game-over #2

Closed
christopho opened this issue Apr 1, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@christopho
Copy link
Collaborator

commented Apr 1, 2017

The pause menu and the dialog box are buggy on some systems: https://www.youtube.com/watch?v=FZyHgcAOEzw
It looks like the dialog box appears twice, as well as the pause menu. Maybe there is the same problem with the game-over menu.
I did not reproduce the bug so far

@Diarandor

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2017

I had 3 different errors with menus or dialog box (open new issues for the ones that are not the same):
-Dialog box duplicated above and below
-Dialog box not cleared (or something like that), so text appears over previous text
-Inventory menus with images in the wrong menu (maybe some index is not updated correclty?)

@MetalES

This comment has been minimized.

Copy link

commented Apr 2, 2017

I did have this issue as well, mostly happen after a game over

@christopho

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 2, 2017

This is all the same bug, for the 3 menus. I still cannot reproduce it.

@christopho

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 2, 2017

Could be a bug of the multi_events script, because this is the first game with menus using it. Or a bug in the engine that we did not encounter before multi_events.

@christopho

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 2, 2017

I can reproduce the same symptoms by opening the pause menu twice instead of once:

game:register_event("on_paused", function(game)
  pause_menu:open()
  pause_menu:open()
end)
@christopho

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 2, 2017

Can anyone test if this commit solves the problem: ec636e9
@Diarandor @MetalES

@MetalES

This comment has been minimized.

Copy link

commented Apr 2, 2017

There is still the bug, you can do it easily.

  • Pause and go to option
  • unpause and die

The menu is opened a lot of time, it depend the number of time you've died.
This might be due to the multiple event, being recalled because the game restarts, and so, declare once again the event on_started ?

I don't know, i didn't looked at the entire Mercuris Chess code yet

@MetalES

This comment has been minimized.

Copy link

commented Apr 2, 2017

Replacing

game:register_event("on_paused", function(game) blablabla

by

function game:on_paused()
pause_menu:open()
end

fixed the issue ... yet I don't know if you use something else in on_paused with the pause menu

@christopho

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 3, 2017

Ohhhhhhhhh that's right! After game-over we register the event again on the same game!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.