Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add a umd format output #200

Closed
JounQin opened this issue Sep 4, 2019 · 3 comments
Closed

Feature Request: Add a umd format output #200

JounQin opened this issue Sep 4, 2019 · 3 comments

Comments

@JounQin
Copy link

@JounQin JounQin commented Sep 4, 2019

As title, I can create a PR for it if you like.

Additional, it would be greater if this module can be wrote as ES Module or TypeScript.

@soldair

This comment has been minimized.

Copy link
Owner

@soldair soldair commented Sep 4, 2019

yeah i use typescript at google pretty much 100% of the time now. Its not a trivial rewrite but its getting close to needing to be done because of refactor for Buffer deprecations etc.

I'm interested in how you'ed like to expose umd but in general i expect people to use rollup/webpack themselves which have commonjs support already.

@JounQin

This comment has been minimized.

Copy link
Author

@JounQin JounQin commented Sep 4, 2019

In some companies, they would prefer CDN bundles for vendor packages.

@JounQin

This comment has been minimized.

Copy link
Author

@JounQin JounQin commented Sep 9, 2019

Just realized it did have umd format output. 🤣
https://unpkg.com/browse/qrcode@1.4.1/build/qrcode.js

@JounQin JounQin closed this Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.