New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 refreshing public page causes fetch url jumble #1068

Closed
rimmartin opened this Issue Jan 27, 2019 · 7 comments

Comments

Projects
3 participants
@rimmartin
Copy link

rimmartin commented Jan 27, 2019

Are you wanting testing to be done on v5? If so

  1. clone and install v5
clone -b release/v5.0.0 https://github.com/solid/node-solid-server.git node-solid-server
cd node-solid-server
npm install
export DEBUG=solid:*
bin/solid-test start --webid --auth oidc --multiuser --port 8443 --ssl-cert /home/roger/NodeProjects/roger-g74s.cert --ssl-key /home/roger/NodeProjects/roger-g74s.key --root ./data 

  1. register a user and go to public folder view

  2. add a sub folder and expand it within the public view; should look good

  3. refresh the public view with the browser

  4. expand the sub folder again and should see a fetch url jumble

Outline.expand: Unable to fetch <https://lisa.localhost:8443isa.localhost/public/bread/>: Failed to load  <https://lisa.localhost:8443isa.localhost/public/bread/> Fetcher: fetch failed: TypeError: https://lisa.localhost:8443isa.localhost/public/bread/ is not a valid URL. status: 999

The url https://lisa.localhost:8443isa.localhost/public/bread/ has a strange insertion of part of itself. Solside shows it too.
I've seen this with my user name I used repeatedly for testing and with one I never used before.

On ubuntu 16.04 with firefox v64.0 nodejs node-v11.1.0-linux-x64

@kjetilk kjetilk added the triage label Jan 27, 2019

@kjetilk

This comment has been minimized.

Copy link
Contributor

kjetilk commented Jan 27, 2019

Are you wanting testing to be done on v5?

Yes, so thanks a lot! We'll have a look!

@rimmartin

This comment has been minimized.

Copy link
Author

rimmartin commented Jan 28, 2019

@kjetilk , good, I'll keep testing. let me know if there should be anything focused on specifically

@megoth megoth added the regression label Feb 4, 2019

@megoth megoth added this to To do in NSS-5.0.0 via automation Feb 4, 2019

@megoth megoth self-assigned this Feb 4, 2019

@megoth

This comment has been minimized.

Copy link
Contributor

megoth commented Feb 4, 2019

I'll take this on to determine where the bug is. If it is in the server, we'll take it on, it not, we might postpone this fix.

@megoth megoth removed the triage label Feb 4, 2019

@megoth megoth moved this from To do to In progress in NSS-5.0.0 Feb 5, 2019

@megoth

This comment has been minimized.

Copy link
Contributor

megoth commented Feb 5, 2019

An update: I was able to reproduce the bug, and think I've pinpointed it to a bug in the server. It seems to be something wrong in lib/ldp-container.js, but I'm working on figuring out exactly where it goes wrong.

@rimmartin

This comment has been minimized.

Copy link
Author

rimmartin commented Feb 6, 2019

Hi @megoth , I'll test as you have need. Glad you narrowed it down!

@kjetilk

This comment has been minimized.

Copy link
Contributor

kjetilk commented Feb 6, 2019

Great stuff. We'll roll another beta once this is fixed.

@megoth

This comment has been minimized.

Copy link
Contributor

megoth commented Feb 6, 2019

I tracked the problem down to the use of relative path in the root property and not handling that in the new ResourceMapper. So this was indeed a regression bug. I'm creating a PR now, should have something ready during the day.

@megoth megoth moved this from In progress to Needs review in NSS-5.0.0 Feb 6, 2019

@kjetilk kjetilk closed this Feb 6, 2019

NSS-5.0.0 automation moved this from Needs review to Done Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment