Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting index.html from root will serve the data browser, not the file itself #1345

Open
megoth opened this issue Nov 7, 2019 · 3 comments
Labels
bug regression Things that used to work in earlier releases

Comments

@megoth
Copy link
Contributor

megoth commented Nov 7, 2019

Based on SolidOS/userguide#7 I became aware that if you request index.html from the root of a storage, it will return the HTML for the data browser instead of the index.html file itself.

E.g. https://megoth.solid.community/ will give another response than https://megoth.solid.community/index.html. The latter is a handy bug for people who want to edit the index.html file though, so before fixing this bug we need to make sure that users have the ability to edit index.html via the data browser using other means.

With the fix in #1341 we do get this feature though, as users can fetch the contents of index.html through "Your stuff" in the Dashboard. This paves the way for a fix for this bug, which would result in the correct HTML being returned, which is also good for the Source, which will show the correct HTML instead of the default HTML for the data browser.

@megoth megoth added this to To do in Data Browser Nov 7, 2019
@megoth
Copy link
Contributor Author

megoth commented Nov 7, 2019

To note: This is only for the index.html in the root folder, not any subfolders.

@jaxoncreed
Copy link
Contributor

@megoth How would you propose allowing users to both edit a root html file via the data browser?

@bourgeoa
Copy link
Member

@megoth @jaxoncreed
there is a request by @timbl that NSS do not use mashlib/dist/index.html (for mashlib it is a temporary hack) but mashlib/dist/databrowser.html which is already available in mashlib (see comments https://github.com/solid/mashlib/pull63)

It should solve the point
The change is to be done in NSS get.js

@melvincarvalho melvincarvalho added bug regression Things that used to work in earlier releases labels Feb 2, 2020
@bourgeoa bourgeoa removed this from To do in Data Browser Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug regression Things that used to work in earlier releases
Projects
None yet
Development

No branches or pull requests

4 participants