Skip to content

/ node-solid-server Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC Integration #330

Closed
wants to merge 183 commits into from
Closed

OIDC Integration #330

wants to merge 183 commits into from

Conversation

@dmitrizagidulin
Copy link
Member

@dmitrizagidulin dmitrizagidulin commented May 2, 2016 •
edited

Server-side implementation of the WebID-OIDC (OpenID Connect) authentication spec.

Major features:

  1. Replaces WebID-TLS authentication with WebID-OIDC. WebID-TLS auth will continue to be available on a maintenance v3.5 branch of solid-server.
  2. Moves tests into one of two directories, /test/unit and /test/integration, corresponding.
  3. Improves post-install "out of the box" user experience -- sets up server front page in multi-user mode, installs default signup & signin apps, etc.
  4. Increases unit and integration test coverage for the server.
@nicola nicola mentioned this pull request May 10, 2016
Merged
9 tasks
@dmitrizagidulin dmitrizagidulin force-pushed the dz_oidc branch 4 times, most recently from c0f7b1a to a961a32 May 11, 2016
@nicola nicola mentioned this pull request May 12, 2016
Closed
13 tasks
@dmitrizagidulin dmitrizagidulin force-pushed the dz_oidc branch 3 times, most recently from 591ce7f to 225ae1b May 13, 2016
@nicola nicola mentioned this pull request May 14, 2016
Closed
@dmitrizagidulin dmitrizagidulin mentioned this pull request May 17, 2016
Closed
@dmitrizagidulin dmitrizagidulin force-pushed the dz_oidc branch 5 times, most recently from 4cba2b9 to 87b046c May 18, 2016
@dmitrizagidulin dmitrizagidulin force-pushed the dz_oidc branch 6 times, most recently from 44b0367 to 53fa942 May 27, 2016
nicola
nicola reviewed May 29, 2016
View changes
lib/identity-provider.js Outdated
IdentityProvider.prototype.post = function (req, res, next) {
if (!req.body) {
/**
<<<<<<< 6477d67eec3b591c4dd226307ff634c1a26e40c6
Copy link
Member

@nicola nicola May 29, 2016

whoops?

Copy link
Member Author

@dmitrizagidulin dmitrizagidulin May 29, 2016

Doh!! Thanks :)

@nicola nicola mentioned this pull request Jun 2, 2016
Closed
21 tasks
@dmitrizagidulin dmitrizagidulin mentioned this pull request Jun 8, 2016
Closed
RubenVerborgh and others added 22 commits Aug 22, 2017
@RubenVerborgh
Implement CORS proxy test without async.
67a6b48
@RubenVerborgh
Implement LDP without async.
ace60c7
@RubenVerborgh
Remove async dependency.
d54f958
@RubenVerborgh
Expose WAC-Allow to browser clients.
5746766
@RubenVerborgh
Verify presence of test DNS entries. (#549)
41da733 
Closes #529.
@dmitrizagidulin
Bump oidc-auth-manager dep to 0.12.0
34ca3a6
@dmitrizagidulin
Expand error message for unverified web id
9a3022a
@dmitrizagidulin
Log whole error in error handler
a710be5
@dmitrizagidulin
Do not check for user header in oidc test
d0b4749
@dmitrizagidulin
Move RS options to oidc-auth-manager initialization
1c09007
@dmitrizagidulin
Add support for external WebIDs registering with username & password
c8e9109
@dmitrizagidulin
Remove solid:inbox from template
8b1dc11
@dmitrizagidulin
Tweak account index page phrasing
49fb741
@dmitrizagidulin
Serve static common/ dir relative to __dirname
c868ab1
@RubenVerborgh @timbl
Disable rejectUnauthorized on the WebID-TLS endpoint. (#561)
0dfc619
@RubenVerborgh @timbl
Add current hash to redirect. (#562)
bc58c7d
@dmitrizagidulin
Add bootstrap.min.css.map to common/css/
cc569a8
@dmitrizagidulin
Fix requirement for additional verification logging in with WebID-TLS
0d9a472
@RubenVerborgh
Remove debug overhead on ACL (#566)
e7d7ec3 
Fixes #558.
@dmitrizagidulin
Update Data Browser html file
928ff50
@RubenVerborgh
Add a /public folder in new accounts (#569)
d45d65d
@RubenVerborgh
Rename the idp option into multiuser (#570)
bae020f 
* Rename the idp option into multiuser.

Closes #515.

* Make renamed configuration options warnings.
@RubenVerborgh
Copy link
Member

@RubenVerborgh RubenVerborgh commented Sep 3, 2017

Has been merged into the v4.0.0 release branch (#572).

@RubenVerborgh RubenVerborgh deleted the dz_oidc branch Sep 4, 2017
tomasklapka
Copy link
Contributor

tomasklapka commented on bae020f Sep 5, 2017 •
edited

assignement just for deletion on the next line?
Aren't the assignement sides flipped?
Shouldn't the argv.multiuser be actually ldp.multiuser?
RubenVerborgh
Copy link
Member

RubenVerborgh commented on bae020f Sep 5, 2017

Good catch, thanks!
RubenVerborgh
Copy link
Member

RubenVerborgh commented on bae020f Sep 5, 2017

Fixed in a6e9fee.
@nicola
Copy link
Member

@nicola nicola commented Sep 11, 2017

do we have OIDC integrated now?

@RubenVerborgh
Copy link
Member

@RubenVerborgh RubenVerborgh commented Sep 11, 2017 •
edited

Yes, in https://github.com/solid/node-solid-server/tree/release/v4.0.0. Aiming for a release by the end of the week.

RubenVerborgh added a commit that referenced this issue Sep 12, 2017
@RubenVerborgh
Add CHANGELOG entry for OIDC (#330).
b588c84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@dmitrizagidulin @bshamblen @RubenVerborgh @nicola @tomasklapka