Skip to content

/ node-solid-server Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed path for default templates and views #577

Merged
merged 1 commit into from Sep 5, 2017
Merged

fixed path for default templates and views #577

merged 1 commit into from Sep 5, 2017

Conversation

@tomasklapka
Copy link
Contributor

@tomasklapka tomasklapka commented Sep 5, 2017

If solid-server is run from different location (ie. requiring solid-server as a library) first time, it cannot find default-* directories because their paths are relative. I'm getting:

ERROR ENOENT: no such file or directory, stat '/home/klip/projects/sendilo/default-templates/new-account'
ERROR ENOENT: no such file or directory, stat '/home/klip/projects/sendilo/default-views'

Fixed when relative paths changed to absolute paths with path.join(__dirname, ...)
@tomasklapka
fixed path for default templates and views
f67d0bd
@RubenVerborgh RubenVerborgh self-requested a review Sep 5, 2017
RubenVerborgh
RubenVerborgh approved these changes Sep 5, 2017
View changes
Copy link
Member

@RubenVerborgh RubenVerborgh left a comment

Thanks, looks great to me!

@RubenVerborgh RubenVerborgh added this to the 4.0.0 milestone Sep 5, 2017
@RubenVerborgh RubenVerborgh merged commit 256beeb into solid:release/v4.0.0 Sep 5, 2017
1 check passed
@tomasklapka tomasklapka deleted the fix/default-dirs branch Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenVerborgh RubenVerborgh

Assignees
No one assigned
Labels
bug ready for merge
Projects
None yet
Milestone
4.0.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tomasklapka @RubenVerborgh