New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error messaging for permissions #801

Merged
merged 2 commits into from Sep 30, 2018

Conversation

Projects
None yet
4 participants
@mohamedmansour
Copy link
Contributor

mohamedmansour commented Sep 29, 2018

If an invalid setup with directory permissions happened, it doesn't mean an invalid port. It usually implies it is a setup error. Add the handling for the mkdir sys call.

Fixes #800

mohamedmansour added some commits Sep 29, 2018

Improve the error messaging for permissions
If an invalid setup with directory permissions happened, it doesn't mean an invalid port. It usually implies it is a setup error. Add the handling for the mkdir sys call.
@kjetilk

This comment has been minimized.

Copy link
Contributor

kjetilk commented Sep 29, 2018

Wooohooo, our first PR after the website went up! Thanks a lot, @mohamedmansour , that's awesome! We're just about to publish a process on how we deal with PRs, we'll discuss that shortly.

@dmitrizagidulin care to review?

@kjetilk kjetilk requested a review from dmitrizagidulin Sep 29, 2018

@kjetilk kjetilk changed the base branch from master to develop Sep 29, 2018

@dmitrizagidulin
Copy link
Member

dmitrizagidulin left a comment

Thanks @mohamedmansour! Looks good to me.

@kjetilk kjetilk merged commit 827a598 into solid:develop Sep 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (joshdcollins) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment