Skip to content

Conversation

@NSeydoux
Copy link

@NSeydoux NSeydoux commented Apr 21, 2020

This PR is simply the result of the npm audit fix command. Note that some vulnerabilities, related to minimist, are not solved by this, and are awaiting on upstream updates.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 174

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 170: 0.0%
Covered Lines: 136
Relevant Lines: 136

💛 - Coveralls

@NSeydoux NSeydoux closed this Apr 21, 2020
@NSeydoux
Copy link
Author

Just noted that there already was an open PR doing exactly the same thing ^^

@RubenVerborgh
Copy link
Member

RubenVerborgh commented Apr 21, 2020

Yeah, and now fixed in c8e8362 🙂

In general, it's not necessary to create PRs for lockfile updates, they are performed regularly and only affect development, not production. It's only when a dependency in package.json itself needs bumping, that fast action is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants