Correct statement about which function gets called #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/solid/solid-namespace/blob/master/index.js#L66 It's `rdf.namedNode`, not `rdf.Namespace` that gets called.
Vinnl
approved these changes
Feb 12, 2020
Vinnl
left a comment
Vinnl
left a comment
There was a problem hiding this comment.
I think this is correct, but since I haven't really been involved with this lib, ideally one of the actual contributors would confirm.
Contributor
Author
|
@JordanShurmer or @dmitrizagidulin you are the two contributors listed in the package.json; can one of you please double-check Vincent's review. |
Contributor
Author
JordanShurmer
approved these changes
Jul 12, 2020
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/solid/solid-namespace/blob/master/index.js#L66
It's
rdf.namedNode, notrdf.Namespacethat gets called.