Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark SPARQL GET at risk #205

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@RubenVerborgh
Copy link
Member

RubenVerborgh commented Jul 24, 2019

Not well specified; not used; dangerous DOS point.

Even better would be to just remove (#206)

@michielbdejong

This comment has been minimized.

Copy link
Contributor

michielbdejong commented Jul 24, 2019

Related: seems that NSS never implemented it, so if that's true then there should be zero apps using it: solid/node-solid-server#962

Our wac-ldp module currently implements is using comunica.

@RubenVerborgh

This comment has been minimized.

Copy link
Member Author

RubenVerborgh commented Jul 24, 2019

@michielbdejong Careful; v0.8 mentions “subset” of SPARQL. If you’re using all of Comunica, your subset if very large (if not complete), so a serious stability (DOS) risk exists (especially if single worker, which I believe it is) and even security (through the SERVICE keyword, but also JSON-LD context lookups). I would strongly advice to at least reduce the feature set if it is not removed altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.