Skip to content

More visible up to date contributing page#755

Closed
woutermont wants to merge 7 commits into
solid:mainfrom
woutermont:fix/more-visible-up-to-date-contributing-page
Closed

More visible up to date contributing page#755
woutermont wants to merge 7 commits into
solid:mainfrom
woutermont:fix/more-visible-up-to-date-contributing-page

Conversation

@woutermont
Copy link
Copy Markdown
Contributor

Following up on the weekly Solid GC meeting of 2022-12-14, I updated the Contributing page, and added it to the main navigation and footer. Since I merged most of the Specification page in it (which was mainly about contributing), I added a script to load the TR table into that page.

woutermont and others added 7 commits December 17, 2022 15:00
Signed-off-by: Wouter Termont <woutermont@gmail.com>
Signed-off-by: Wouter Termont <woutermont@gmail.com>
Signed-off-by: Wouter Termont <woutermont@gmail.com>
Signed-off-by: Wouter Termont <woutermont@gmail.com>
Signed-off-by: Wouter Termont <woutermont@gmail.com>
@timea-solid
Copy link
Copy Markdown
Member

timea-solid commented Mar 2, 2023

@woutermont this is a lot of work! Thank you.
However, it is a huge PR and quite hard to follow. You added a lot of changes in one PR. I wonder if it is not possible to break it out into more PRs: changes to the navigation and changes to the content of different pages.
P.s. Meanwhile the team page changed and the new changes are not part of this PR.

@woutermont
Copy link
Copy Markdown
Contributor Author

@timea-solid, it's really just a minor update; the navigation is not changed, just replaced to maintain some balance in the footer/dropdowns.

If you really want to split this up, I can look into it, but I don't know when; I am on sick leave for the foreseable future, and uncertain if/when I will find the energy.

@timea-solid
Copy link
Copy Markdown
Member

@timea-solid, it's really just a minor update; the navigation is not changed, just replaced to maintain some balance in the footer/dropdowns.

If you really want to split this up, I can look into it, but I don't know when; I am on sick leave for the foreseable future, and uncertain if/when I will find the energy.

This does not have a high prio so please rest.
It was hard to follow through with the changes and the merges still needed. Also, it is easier to vote on/agree upon as a team if it is broken down. In this case, someone might not agree with the menu moving but agree with your content and vice-versa.

@woutermont
Copy link
Copy Markdown
Contributor Author

Hi @timea-solid, I am slowely trying to work a bit again. I split this PR up into the following (one per page):

I left the navigation changes out, even though I still believe them to be necessary in order for people to find the contribution pages (and others) more easily.

I also pushed #794, which fixes some problems with the tooling, which had not been updated in two years.

@woutermont woutermont closed this Jul 9, 2023
@csarven
Copy link
Copy Markdown
Member

csarven commented Jul 10, 2023

Noting here that this PR (and following specific PRs) is one of the good examples of Solid CG interacting/coordinating with Solid Project / Team following a CG discussion/action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants