Skip to content

replace SolidStart templates with the ones in templates repository #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

replace SolidStart templates with the ones in templates repository #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create/src/create-start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export type CreateStartArgs = {
export const createStartTS = ({ template, destination }: CreateStartArgs) => {
return downloadRepo(
{
repo: { owner: "solidjs", name: "solid-start", subdir: `examples/${template}` },
repo: { owner: "solidjs", name: "templates", subdir: `solid-start/${template}` },
dest: destination,
},
GithubFetcher,
Expand Down
12 changes: 6 additions & 6 deletions packages/create/src/utils/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ const VANILLA_TEMPLATES = [
] as const satisfies string[];
export type VanillaTemplate = (typeof VANILLA_TEMPLATES)[number];

/**Supported Start Templates */
/**
* @description This list is hardcoded. But templates are fetched from another github repo.
* @see https://github.com/solidjs/templates/tree/main/solid-start
*/
const START_TEMPLATES = [
"basic",
"bare",
"hackernews",
"notes",
"todomvc",
"with-solidbase",
"with-auth",
"with-authjs",
Expand All @@ -79,8 +79,8 @@ const START_TEMPLATES = [
"with-unocss",
"with-vitest",
"with-strict-csp",
"experiments",
] as const satisfies string[];

export type StartTemplate = (typeof START_TEMPLATES)[number];

/**Supported Library Templates */
Expand Down Expand Up @@ -118,5 +118,5 @@ export function isValidTemplate(type: "start", maybe_template: string): maybe_te
export function isValidTemplate(type: "library", maybe_template: string): maybe_template is LibraryTemplate;
export function isValidTemplate(type: ProjectType, maybe_template: string) {
const templates = getTemplatesList(type);
return templates.find(t => t === maybe_template) !== undefined
return templates.find((t) => t === maybe_template) !== undefined;
}
Loading