Skip to content

Commit

Permalink
Remove unutilized coffee-rails dependency
Browse files Browse the repository at this point in the history
All coffee script has been translated into vanilla javascript and no
longer requires the gem coffee-rails. This PR removes the dependency
and all associated language associated with utilization of the gem.
  • Loading branch information
cpfergus1 committed Jun 6, 2022
1 parent 4cc1d5a commit a4a571c
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .editorconfig
Expand Up @@ -15,7 +15,7 @@ tab_width = 2
[**.rb]
max_line_length = 80

[**.js, **.coffee]
[**.js]
max_line_length = 120

[*.md]
Expand Down
7 changes: 1 addition & 6 deletions backend/README.md
Expand Up @@ -8,12 +8,7 @@ Backend contains the controllers, views, and assets making up the admin interfac

Can be found in [app/assets/javascripts/spree/backend/](./app/assets/javascripts/spree/backend/)

Our scripts are written in a mix of CoffeeScript and JavaScript (ES5). We can't
easily use a transpiler for ECMAScript >= 6 without adding additional steps for
applications using solidus\_admin.

Though we have existing CoffeeScript files, any new files should be in
JavaScript (ES5).
Any new files should be in JavaScript (ES5).

### Stylesheets

Expand Down
1 change: 0 additions & 1 deletion backend/lib/spree/backend.rb
Expand Up @@ -4,7 +4,6 @@
require 'spree_api'

require 'jquery-rails'
require 'coffee-rails'
require 'sassc-rails'
require 'handlebars_assets'
require 'font-awesome-rails'
Expand Down
1 change: 0 additions & 1 deletion backend/solidus_backend.gemspec
Expand Up @@ -26,7 +26,6 @@ Gem::Specification.new do |s|
s.add_dependency 'solidus_api', s.version
s.add_dependency 'solidus_core', s.version

s.add_dependency 'coffee-rails'
s.add_dependency 'font-awesome-rails', '~> 4.0'
s.add_dependency 'jbuilder', '~> 2.8'
s.add_dependency 'jquery-rails'
Expand Down
2 changes: 1 addition & 1 deletion backend/spec/teaspoon_env.rb
Expand Up @@ -31,7 +31,7 @@

config.suite do |suite|
suite.use_framework :mocha, "2.3.3"
suite.matcher = "{spec/javascripts,app/assets}/**/*_spec.{js,js.coffee,coffee}"
suite.matcher = "{spec/javascripts,app/assets}/**/*_spec.js"
suite.helper = "spec_helper"
suite.boot_partial = "/boot"
suite.expand_assets = true
Expand Down
@@ -1,5 +1,5 @@
// This is a manifest file that'll be compiled into including all the files listed below.
// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically
// Add new JavaScript code in separate files in this directory and they'll automatically
// be included in the compiled file accessible from http://example.com/assets/application.js
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
// the compiled file.
Expand Down
@@ -1,5 +1,5 @@
// This is a manifest file that'll be compiled into including all the files listed below.
// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically
// Add new JavaScript code in separate files in this directory and they'll automatically
// be included in the compiled file accessible from http://example.com/assets/application.js
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
// the compiled file.
Expand Down
@@ -1,5 +1,5 @@
// This is a manifest file that'll be compiled into including all the files listed below.
// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically
// Add new JavaScript code in separate files in this directory and they'll automatically
// be included in the compiled file accessible from http://example.com/assets/application.js
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
// the compiled file.
Expand Down
@@ -1,5 +1,5 @@
// This is a manifest file that'll be compiled into including all the files listed below.
// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically
// Add new JavaScript code in separate files in this directory and they'll automatically
// be included in the compiled file accessible from http://example.com/assets/application.js
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
// the compiled file.
Expand Down

0 comments on commit a4a571c

Please sign in to comment.