New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Products at mulitple Stock Locations appear as unique variants #2868
Comments
Hi @jacobherrington , I am able to reproduce this issue in my local machine and tried to fix. I guess I would be able to fix this. |
Please do @mayanktap! Let me know if you need help and I'll try to give you some guidance. :) |
@jacobherrington , According to my understanding and investigation, I made some changes and tested it thoroughly. I will raise the PR so that you can review and take decision accordingly. I want to verify one point regarding the process of raising PR: |
Also , Is there any naming convention regarding the name of the branch? I didn't find anything related to this in CONTRIBUTION documentation. |
Wow that's great 🎉 Yes, we usually branch off of master and PR back to master and branch names aren't a big deal to Solidus. Thanks a ton for your help! 👍 |
Ok then I will raise the PR after another round of testing. |
@jacobherrington . Please check the above PR #2898 raised corresponding to the issue. |
Variants are counted multiple times when they have stock in multiple stock locations. Adding `distinct` fixes this behavior. Fixes solidusio#2868
Variants are counted multiple times when they have stock in multiple stock locations. Adding `distinct` fixes this behavior. Fixes solidusio#2868
Please refer to this new PR(#3063) for the fix of this issue. |
Steps to reproduce
1. Create a store with two (or three) Stock Locations.
2. Choose a product with no variants (I used the RoR Mug).
3. Add stock to the product in each location.
4. Create a new order from
admin/orders
and try to add the item. You will see the two (or three) variants with the same SKU.Expected behavior
One variant should exist in the dropdown, regardless of the number of Stock Locations.
Please correct me if this is not ideal.
Actual behavior
There are as many variants listed in the drop down as there are Stock Locations with stock.
System configuration
Solidus Version: 2.7.0
Extensions in use: Sandbox
The text was updated successfully, but these errors were encountered: