Products at mulitple Stock Locations appear as unique variants

[jacobherrington]

Steps to reproduce

1. Create a store with two (or three) Stock Locations.

2. Choose a product with no variants (I used the RoR Mug).
3. Add stock to the product in each location.

4. Create a new order from admin/orders and try to add the item. You will see the two (or three) variants with the same SKU.

Expected behavior

One variant should exist in the dropdown, regardless of the number of Stock Locations.

Please correct me if this is not ideal.

Actual behavior

There are as many variants listed in the drop down as there are Stock Locations with stock.

System configuration

Solidus Version: 2.7.0

Extensions in use: Sandbox

[mayanktap]

Hi @jacobherrington , I am able to reproduce this issue in my local machine and tried to fix. I guess I would be able to fix this.
I would like to work on this. Can I ?

[jacobherrington]

Please do @mayanktap! Let me know if you need help and I'll try to give you some guidance. :)

[mayanktap]

@jacobherrington , According to my understanding and investigation, I made some changes and tested it thoroughly. I will raise the PR so that you can review and take decision accordingly.
I would just need some guidance in the process of making PR.

I want to verify one point regarding the process of raising PR:
1.) I am raising PR as base branch as master. That means the new branch that I will create to push the change will be from master branch. Is it correct?

[mayanktap]

Also , Is there any naming convention regarding the name of the branch? I didn't find anything related to this in CONTRIBUTION documentation.

[jacobherrington]

Wow that's great 🎉

Yes, we usually branch off of master and PR back to master and branch names aren't a big deal to Solidus.

Thanks a ton for your help! 👍

[mayanktap]

Ok then I will raise the PR after another round of testing.

[mayanktap]

@jacobherrington . Please check the above PR #2898 raised corresponding to the issue.

[mayanktap]

Please refer to this new PR(#3063) for the fix of this issue.