New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Support Rails 6 #3053

Open
jarednorman opened this Issue Jan 25, 2019 · 4 comments

Comments

Projects
None yet
5 participants
@jarednorman
Copy link
Member

jarednorman commented Jan 25, 2019

The first Rails 6 beta is out, so we can start discussing how we're going to support that. When the project moved from Rails 4.x to Rails 5, we cut a major version that introduced no new features and only upgraded the codebase for compatibility. Depending on the extent of the changes in Rails 6, something that big might not be necessary.

I'm opening this issue to gather comments/discussion on Rails 6 support for Solidus.

@jarednorman jarednorman changed the title Support Rails 6 RFC: Support Rails 6 Jan 25, 2019

@mdesantis

This comment has been minimized.

Copy link
Contributor

mdesantis commented Jan 28, 2019

One thought about Rails 6 and ActionText: are there any places in Solidus where we'd like to use it? Any places where we write rich text?

@kennyadsl

This comment has been minimized.

Copy link
Member

kennyadsl commented Feb 1, 2019

@mdesantis solidus_editor is what is used for this kind of things most of the times, I think.

@ericsaupe

This comment has been minimized.

Copy link
Contributor

ericsaupe commented Feb 5, 2019

This one too solidus_static_content. I fired up a new Rails 6 app with ActionText and it worked pretty well. Definitely could make those extensions cleaner. It works with ActiveStorage so it might be something that benefits from #2974

@jarednorman

This comment has been minimized.

Copy link
Member Author

jarednorman commented Feb 14, 2019

I've been live streaming myself working on this. Here's the YouTube playlist of past streams.

The biggest issue I've run into so far is that there are some really annoying incompatibilities with newer versions of CanCanCan. I've been running against the branch that has Rails 6 support, and it's caused a whole bunch of unrelated issues.

I'll continue working away on that. I haven't opened a progress PR because I'm waiting on releases on a bunch of the gems that will need to be bumped to support Rails 6. Currently I'm just pointing at various GitHub branches that contain the tentative work on Rails 6 support for those gems.

I've got core passing, and backend/frontend almost completely passing if I comment out the stuff in the permission sets that are causing the CanCanCan headaches. API is full of failing specs and I haven't dug into that, but I imagine it's at least partially related to the authorization issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment