Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
RFC: Support Rails 6 #3053
The first Rails 6 beta is out, so we can start discussing how we're going to support that. When the project moved from Rails 4.x to Rails 5, we cut a major version that introduced no new features and only upgraded the codebase for compatibility. Depending on the extent of the changes in Rails 6, something that big might not be necessary.
I'm opening this issue to gather comments/discussion on Rails 6 support for Solidus.
I've been live streaming myself working on this. Here's the YouTube playlist of past streams.
The biggest issue I've run into so far is that there are some really annoying incompatibilities with newer versions of CanCanCan. I've been running against the branch that has Rails 6 support, and it's caused a whole bunch of unrelated issues.
I'll continue working away on that. I haven't opened a progress PR because I'm waiting on releases on a bunch of the gems that will need to be bumped to support Rails 6. Currently I'm just pointing at various GitHub branches that contain the tentative work on Rails 6 support for those gems.
I've got core passing, and backend/frontend almost completely passing if I comment out the stuff in the permission sets that are causing the CanCanCan headaches. API is full of failing specs and I haven't dug into that, but I imagine it's at least partially related to the authorization issues.