Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove Paranoia #3393

Open
jarednorman opened this issue Oct 23, 2019 · 2 comments

Comments

@jarednorman
Copy link
Member

@jarednorman jarednorman commented Oct 23, 2019

We committed previously to fully moving from paranoia to discard in #2354. The initial work was completed and all models that "act as paranoid" include Spree::ParanoiaDeprecations which warns users that we are removing the paranoia gem from the project and that destroy is actually going to destroy things in the future. All of those models also include Discard::Model and are ready to be fully switched over.

In order to complete the switchover, I believe we need to:

  1. Make sure we are using the kept scope as appropriate everywhere we need to. This isn't a small task, but is totally achievable. This work can be merged prior to actually removing the paranoia gem as it won't actually affect the behaviour of the system.
  2. Remove the paranoia gem, all the references to acts_as_paranoid, and the Spree::ParanoiaDeprecations mixin. As the deprecation warns, this is a breaking change and should likely be included in next major release after it is merged.

Does anyone have any concerns about following through on this work and removing paranoia in the next major release?

@awinabi

This comment has been minimized.

Copy link

@awinabi awinabi commented Oct 25, 2019

@jacobherrington I can take an attempt at this, if its open for work

@jarednorman

This comment has been minimized.

Copy link
Member Author

@jarednorman jarednorman commented Oct 25, 2019

I've cleaned out the outstanding issues/pull requests on the Discard project (I maintain it) and have started working on this, but assistance will be helpful. We're looking at using something like the functionality mentioned in this Discard issue to ensure that we don't miss any queries. I'm going to post a checklist of all the models that need to be migrated in the description of this task to make sure we don't duplicate work or miss anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.