Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue 2868: Products at mulitple Stock Locations appear as unique variants. #2898
changed the title from
Issue 2868: Repetation of same variant in case of different stock location.
Issue 2868: Products at mulitple Stock Locations appear as unique variants.
Oct 6, 2018
referenced this pull request
Oct 6, 2018
I think this addresses it nicely.
A couple of notes, I would redo your commit message to better describe what is actually being changed and, if possible, write a regression test that fails for current versions of Solidus but is resolved with your fix.
Actually, I am familiar in using GIT from terminal instead from UI and because of that I was not able to figure out where GIT commit message is to be changed. I will make the necessary changes in the commit message.
Regarding the failing test, I check the test case and tried to run the test with and without my code which leads to the failing of same test. So as per my understanding, the failing of test case is not because of the this change.
@mayanktap sure! Basically, a test that would do something like this:
That's a very simple test that is obviously mostly pseudocode but the idea is that you're going to call the
Does that make sense?