From c14ad0ba3954f25394252c5bd0638213e19110be Mon Sep 17 00:00:00 2001 From: Juan Carlos Ruiz Date: Fri, 22 Feb 2019 14:06:08 -0600 Subject: [PATCH 1/2] Add adjustments docs link on promotions overview --- guides/source/developers/promotions/overview.html.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/guides/source/developers/promotions/overview.html.md b/guides/source/developers/promotions/overview.html.md index 2df2a99812a..fde75e32d9b 100644 --- a/guides/source/developers/promotions/overview.html.md +++ b/guides/source/developers/promotions/overview.html.md @@ -116,12 +116,10 @@ Every time that the promotion adjustment needs to be recalculated, the `Spree::PromotionRule`s are re-checked to ensure the promotion is still eligible. -Note that shipments and taxes can also create adjustments. See the adjustments +Note that shipments and taxes can also create adjustments. See the [adjustments][adjustments] documentation for more information. - +[adjustments]: ../adjustments/overview.html ## Eligibility From 763b3dccc33329e3953b2ad2ce184a10696da9a9 Mon Sep 17 00:00:00 2001 From: Juan Carlos Ruiz Date: Fri, 22 Feb 2019 14:17:05 -0600 Subject: [PATCH 2/2] remove docs eligible? method line number The promotions documentation `def eligible?` method line number is unnecessary this updates the documentation reference removing the line number. --- guides/source/developers/promotions/overview.html.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guides/source/developers/promotions/overview.html.md b/guides/source/developers/promotions/overview.html.md index fde75e32d9b..06740935e71 100644 --- a/guides/source/developers/promotions/overview.html.md +++ b/guides/source/developers/promotions/overview.html.md @@ -138,7 +138,7 @@ See the `eligible?` method defined in the [Spree::Promotion model][spree-promotion]: ```ruby -# models/spree/promotion.rb : line 123 +# models/spree/promotion.rb def eligible?(promotable, promotion_code: nil) return false if inactive? return false if usage_limit_exceeded?