Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added location_filter_class as a writable attribute #3330

Open
wants to merge 1 commit into
base: master
from

Conversation

@ericsaupe
Copy link
Contributor

commented Sep 10, 2019

Description

The other stock configuration classes are all configurable
but location_filter_class was missing the attr_writer.
Also includes specs for location_filter_class and
allocator_class configurations.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
Added location_filter_class as a writable attribute
The other stock configuration classes are all configurable
but location_filter_class was missing the attr_writer.
Also includes specs for location_filter_class and
allocator_class configurations.
@kennyadsl
Copy link
Member

left a comment

@ericsaupe makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.