[API] Add bang method when finding product property #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the controller does not find the product property it cannot return an invalid resource response for that record and then it breaks with 500. This commit adds the bang method so that the controller can rely on the base controller rescue_from ActiveRecord::RecordNotFound https://github.com/solidusio/solidus/blob/v2.10.0/api/app/controllers/spree/api/base_controller.rb#L28 to return a proper message.
kennyadsl
changed the title
kennyadsl
added
Code Review Needed
changelog:solidus_api
spaghetticode
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the controller does not find the product property it cannot return an invalid resource response for that record and then it breaks with 500.
This commit adds the bang method so that the controller can rely on the base controller rescue_from ActiveRecord::RecordNotFound to return a proper message.
Checklist: