Update taxon icon to use present instead of exists #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
requested changes
Jan 3, 2021
`Exists` on a paperclip object attempts to access the image where it's stored, whereas present just checks if the object exists on Solidus. Using exists here causes an error if the image doesn't exist. Luckily, paperclip double checks that the image filename is present before attempting to fetch it from the storage service, but paperclip_cloudinary does not do this, meaning that any store using paperclip_cloudinary is unable to view the admin taxon edit page for taxons without icons.
seand7565
force-pushed
the
exist-rename
branch
from
3169a82
to
6e19cd7
Compare
jarednorman
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exists?on a paperclip object attempts to access the image whereit's stored, whereas
present?just checks if the object exists onSolidus.
Using
exists?here causes an error if the image doesn't exist. Luckily,paperclip double checks that the image filename is present before
attempting to fetch it from the storage service, but paperclip_cloudinary
does not do this, meaning that any store using paperclip_cloudinary is
unable to view the admin taxon edit page for taxons without icons.
This was an issue on the demo store, which uses paperclip_cloudinary. I've patched it up there, but figured I should add a fix here as well.
Checklist: