Remove Rails v5.2 support #4850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails v5.2 is EOL since 01 Jun 2022 [1]. Our new release policy [2] makes it clear that we don't support Rails versions that are no longer maintained. [1] - https://endoflife.date/rails [2] - https://solidus.io/release_policy/
github-actions
bot
added
changelog:solidus_api
elia
approved these changes
Jan 12, 2023
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_rails_v5.2_support
branch
from
813a6f1
to
13d31e8
Compare
kennyadsl
reviewed
Jan 12, 2023
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_rails_v5.2_support
branch
from
13d31e8
to
aea7fd0
Compare
kennyadsl
reviewed
Jan 13, 2023
We no longer support Rails v5.2, so there's no need to support the old way [1]. As we only need to include a Rails module, there's neither the need to go through a custom module. [1] - rails/rails@e33c3cd
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_rails_v5.2_support
branch
from
aea7fd0
to
a3119d5
Compare
kennyadsl
approved these changes
Jan 13, 2023
|
This PR is missing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rails v5.2 is EOL since 01 Jun 2022.
Our new release policy makes it clear that we don't support Rails versions that are no longer maintained.
We also remove the indirection to set current host for ActiveStorage. As we only need to include a Rails module, there's neither the need to go through a custom module.
Closes #4842
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the README to account for my changes.