Permalink
Commits on Mar 14, 2012
  1. Add pending spec examples

    committed Mar 14, 2012
  2. Update TODO

    committed Mar 14, 2012
  3. Adjust flay threshold

    committed Mar 14, 2012
Commits on Mar 13, 2012
  1. Adjust flay threshold

    committed Mar 13, 2012
Commits on Mar 12, 2012
  1. @dkubb

    Update flay threshold

    dkubb committed Mar 12, 2012
  2. @dkubb
  3. @dkubb
  4. @dkubb

    Update reek thresholds

    dkubb committed Mar 12, 2012
  5. @dkubb

    Change Virtus::InstanceMethods#initialize to not create an empty hash…

    … by default
    
    * When no arguments are passed in, the end result is the same as when a nil is
      passed in, so there's no need to create an empty Hash and then "set" the
      internal state with it. Better to just default to nil, and short-circuit the
      call.
    * Added specs so that if anything other than nil or an object that responds to
      #to_hash is passed in an exception is raised. Like DM1, by default I *only*
      want constructors handling Hash-like objects or nil; anything else passed in
      should be considered an exceptional case.
    dkubb committed Mar 12, 2012
  6. @dkubb

    Merge pull request #79 from fgrehm/fix-mass-assignment-with-nil

    Do not throw exception when nil is passed to #attributes=
    dkubb committed Mar 12, 2012
  7. @dkubb
  8. @fgrehm

    Copy & paste is evil :P

    fgrehm committed Mar 12, 2012
  9. @fgrehm
  10. @fgrehm

    Change InstanceMethods#initialize to check if object can be duck type…

    …d to hash instead of checking if not nil
    fgrehm committed Mar 12, 2012
Commits on Mar 11, 2012
  1. @fgrehm
  2. @fgrehm
  3. @fgrehm
Commits on Mar 2, 2012
  1. @fgrehm
Commits on Mar 1, 2012
  1. @dkubb

    Update flay threshold

    dkubb committed Mar 1, 2012
  2. @dkubb

    Refactor Virtus::Coercion::String.to_constant

    * Split constant lookup into a private method
    dkubb committed Mar 1, 2012
  3. @dkubb
  4. @dkubb
  5. @dkubb
  6. @dkubb

    Refactor Virtus::Attribute::Collection#coerce

    * The names of the arguments passed into #coerce_and_append_member isn't an
      important detail for #coerce to know about, so just pass in all the args as-is
    dkubb committed Mar 1, 2012
  7. @dkubb

    Add specs for Virtus::Attribute::Collection#coerce

    * The existing specs only tested two out of 3 possible states the method could
      exist in. Add another spec to cover the actual "happy path" when
      #coerce_and_append_member is implemented for the Collection subclass.
    dkubb committed Mar 1, 2012
Commits on Feb 29, 2012
  1. @dkubb

    Fix spec by replacing the mock with an Object instance

    * For some reason RSpec::Mocks::Mock defines #to_str in rspec 2, and with the
      spec we're trying to assert what will happen when a non-String-like object is
      passed to the string coercion method.
    dkubb committed Feb 29, 2012
  2. @dkubb

    Fix specs to use the proper "from" value

    * It looks like rspec 1 does not check the "from" value, only the "to" value,
      so make this change to allow the specs to pass with rspec 2.
    dkubb committed Feb 29, 2012
  3. @dkubb
Commits on Feb 26, 2012
  1. Fix whitespace

    committed Feb 26, 2012
  2. Merge remote-tracking branch 'fgrehm/adjust-readme'

    Conflicts:
    	README.md
    committed Feb 26, 2012
  3. Update README.md

    committed Feb 26, 2012