Disallow mutation of ValueObjects via #attributes= #108

Merged
merged 1 commit into from Jul 28, 2012

Conversation

Projects
None yet
3 participants
Collaborator

mbj commented Jul 27, 2012

Increases consistency as mutations on value objects should be created via #with(mutations).

Markus Schirp
Disallow mutation of ValueObjects via #attributes=
* Increases consistency as mutations on value objects should be
  created via #with(mutations).
Collaborator

dkubb commented Jul 28, 2012

This seems great to me.

@solnic I'm going to merge this, let me know if you disagree and we can discuss or revert.

dkubb added a commit that referenced this pull request Jul 28, 2012

Merge pull request #108 from mbj/fix-mutations-on-value-objects
Disallow mutation of ValueObjects via #attributes=

@dkubb dkubb merged commit f21b149 into solnic:master Jul 28, 2012

Owner

solnic commented Jul 28, 2012

My only concern is that the build failed :)

On Saturday, 28 July 2012 at 19:11, Dan Kubb wrote:

This seems great to me.

@solnic I'm going to merge this, let me know if you disagree and we can discuss or revert.


Reply to this email directly or view it on GitHub:
#108 (comment)

Collaborator

dkubb commented Jul 28, 2012

@solnic although the failures are caused by problems on travis' end. In the cases where it failed, our build scripts never got a chance to execute.

Collaborator

mbj commented Jul 28, 2012

@dkubb, @solnic Im having the same rbx problems with my projects also. Seems rbx is broken on travis currently. Thx for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment