Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support grpc-web envoy filter #555

Closed
ilackarms opened this Issue Mar 18, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@ilackarms
Copy link
Member

ilackarms commented Mar 18, 2019

it's a simple filter that simply needs to be inserted in the http filter chain. docs: https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/grpc_web_filter

i suggest gating it behind a ListenerPlugin, which means the user will need to update the Gateway crd in order to get the feature. it lives on the filter level though, so it's misleading to put it on a virtualservice

yuval-k added a commit that referenced this issue Mar 18, 2019

soloio-bulldozer bot added a commit that referenced this issue Mar 18, 2019

add grpc web support; enabled by default with option to disable. (#556)
* add grpc web support; enabled by default with option to disabled. fixes  #555
* changelog
* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.