Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't swallow error if pre-install fails #571

Closed
rickducott opened this issue Mar 20, 2019 · 1 comment
Closed

Don't swallow error if pre-install fails #571

rickducott opened this issue Mar 20, 2019 · 1 comment

Comments

@rickducott
Copy link

Typo caused by this refactor #564

Doesn't affect Gloo because Gloo currently doesn't have a pre-install hook in it's chart, but fixing before it affects stuff.
@rickducott
Copy link
Author

Update: this could be a problem where we silently don't create custom settings and use default settings, if settings.create was set to true during install.

This was referenced Mar 20, 2019
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rickducott