This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix --name to helm install as it uses an incorrect name; names cannot… #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have periods in them
scranton
approved these changes
Mar 20, 2019
baiweiyll
pushed a commit
to baiweiyll/solo-docs
that referenced
this pull request
Oct 28, 2019
* Update tests to run everything * try again * Updated dir * Try again * Trying with gopath set * Update to solo-kit and build, now generated tests are running * Update to test solo kit * Start migrating to new generation * Update to new solo kit generation * Update to 0.2.7 * Fix compile issue and make test pass * Fix kubernetes test for GKE * Update solo kit again * Fix generated tests * Fix test * Update to new template * Regen emitter tests * Patch for setup because it wasn't getting regen * Fix regen * Update to solo-kit 0.2.8 * Revert to only running e2es like before, so branch can merge * Fix ordering * fully qualified package name * dep now moves things out of /workspace into the github folder, so let's do dep first * Fix path since ci directory now lives in proper gopath location
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… have periods in them