Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s 1.26 upgrade #542

Merged
merged 16 commits into from
May 19, 2023
Merged

K8s 1.26 upgrade #542

merged 16 commits into from
May 19, 2023

Conversation

inFocus7
Copy link
Contributor

@inFocus7 inFocus7 commented May 18, 2023

  • upgrade k8s dependencies to 1.26
  • update go-utils to v0.24.2
  • Upgrade to a released k8s-utils version that has 1.26 bumps

@inFocus7
Copy link
Contributor Author

inFocus7 commented May 18, 2023

tried generating code locally with make clean generate-all -B, but got an error

"Thu, 18 May 2023 09:58:36 EDT: github.com/solo-io/solo-kit/generate.go:37"     generate failed!: &errors.withStack{
  error: &errors.withMessage{
    cause: &exec.ExitError{
      ProcessState: &os.ProcessState{
        pid:    74978,
        status: 0x00000100,
        rusage: &syscall.Rusage{
          Utime: syscall.Timeval{
            Sec:       0,
            Usec:      6536,
            Pad_cgo_0: [4]uint8{
              0x00, 0x00, 0x00, 0x00,
            },
          },
          Stime: syscall.Timeval{
            Sec:       0,
            Usec:      3659,
            Pad_cgo_0: [4]uint8{
              0x00, 0x00, 0x00, 0x00,
            },
          },
          Maxrss:   6389760,
          Ixrss:    0,
          Idrss:    0,
          Isrss:    0,
          Minflt:   784,
          Majflt:   0,
          Nswap:    0,
          Inblock:  0,
          Oublock:  0,
          Msgsnd:   0,
          Msgrcv:   0,
          Nsignals: 0,
          Nvcsw:    3,
          Nivcsw:   4,
        },
      },
      Stderr: []uint8{},
    },
    msg: "[protoc -I/Users/fabiangonz98/go/src/github.com/solo-io/solo-kit/vendor_any -I/Users/fabiangonz98/go/src/github.com/solo-io/solo-kit/vendor_any/github.com/solo-io/protoc-gen-ext/external -I/Users/fabiangonz98/go/src/github.com/solo-io/solo-kit/vendor_any/github.com/envoyproxy/protoc-gen-validate -I/Users/fabiangonz98/go/src/github.com/solo-io/solo-kit/vendor_any/github.com/solo-io/protoc-gen-ext -I/Users/fabiangonz98/go/src/github.com/solo-io/solo-kit/vendor_any/github.com/solo-io/solo-kit/api/external --openapi_out=yaml=true,single_file=false,include_description=true,enum_as_int_or_string=false,additional_empty_schema=core.solo.io.Status:/var/folders/5_/gy4y2g551_dcsykch8xy07sh0000gn/T/549943686/mock_resources -o /var/folders/5_/gy4y2g551_dcsykch8xy07sh0000gn/T/schema-gen-560651527 --include_imports --include_source_info github.com/solo-io/solo-kit/test/mocks/api/v1/mock_resources.proto] failed: github.com/solo-io/solo-kit/test/mocks/api/v1/mock_resources.proto: warning: Import google/protobuf/any.proto but not used.\ngithub.com/solo-io/solo-kit/test/mocks/api/v1/mock_resources.proto: warning: Import google/protobuf/struct.proto but not used.\nprotoc-gen-openapi: program not found or is not executable\n--openapi_out: protoc-gen-openapi: Plugin failed with status code 1.\n",
  },
  stack: &errors.stack{
    0x1051615ec,
    0x10516157d,
    0x10525dc9c,
    0x10525d9b4,
    0x10525cad8,
    0x10529515c,
    0x105293eac,
    0x1052974b0,
    0x104a4bfa0,
    0x104a78ec4,
  },
}
exit status 1

update: 🤦🏼 make update-all generated-code -B is the correct command

@inFocus7
Copy link
Contributor Author

looks like my codegen differs from the build-bot one :rip:

@inFocus7
Copy link
Contributor Author

missing some generated code that didn't occur on my end

…externalversions/factory.go for CI codegens failure
@solo-changelog-bot
Copy link

Issues linked to changelog:
solo-io/gloo#8164

@inFocus7
Copy link
Contributor Author

Reverted my try to move tests to GH Actions + created an issue for it #543

github.com/onsi/gomega v1.24.1
github.com/pkg/errors v0.9.1
github.com/pseudomuto/protoc-gen-doc v1.5.1
github.com/pseudomuto/protoc-gen-doc v1.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why this got downgraded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure, i'll check go-utils & k8s-utils to see which might've done it :hmm:

Copy link
Contributor Author

@inFocus7 inFocus7 May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure. looks like it was part of this commit where i bumped k8s-utils to a specific commit before its release. I think I can go get github.com/pseudomuto/protoc-gen-doc@v1.5.1 if you think that'd be safer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably not a big deal, just curious that something caused it to downgrade

@soloio-bulldozer soloio-bulldozer bot merged commit 8bd9a4a into main May 19, 2023
@soloio-bulldozer soloio-bulldozer bot deleted the k8s-1.26-upgrade branch May 19, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants