Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove annotations prometheus configmaps #287

Closed
ilackarms opened this issue Mar 22, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@ilackarms
Copy link
Member

commented Mar 22, 2019

currently prometheus configmaps require an annotation resource_kind: v1PrometheusConfig in order to be processed (rather than ignored) by solo-kit resource clients.

this is not user-friendly as those annotations are not part of any standard. we should obviate the need for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.