Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enable/disable ingress and egress (Istio) #403

Closed
peterj opened this issue Apr 26, 2019 · 7 comments

Comments

Projects
None yet
2 participants
@peterj
Copy link
Contributor

commented Apr 26, 2019

The gatewayInstallOptions is never set in the helmChartParams, so by default when installing Istio, ingress/egress gateway does not get installed (not sure if this is by design or not).

@ilackarms

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@peterj it was installed for the first iterations of the installer, but turned off due to some issues it was causing. we do intend to bring it back, but have been focused on other stuff.

is this a priority for you? it's a relatively simple change to make; in fact, a PR would be great if you think you could handle it with some guidance.

definitely on our roadmap. for now i would recommend installing istio via the helm chart and running supergloo with mesh-discovery

@ilackarms

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

note that for certificate rotation to work, if istio isn't a managed install, you will need to re-run the helm chart yourself with --set security.selfSigned=true/false (false when configuring a custom root ca with supergloo, true when removing the custom ca config and telling istio to sign its own certificate)

this is a known issue that we're also working to address

@peterj

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

Not a high priority, I was just playing with it and noticed that it's defined, but not actually set anywhere.

I can take a stab at it and create a PR. Seems like it's a matter of updating the install.proto to include the two options (ingress/egress), add the flags to the CLI and include the gatewayInstallOptions instance in the helmChartParams in makeManifestsForInstall (+ adding/updating unit tests).

@ilackarms

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

yes! exactly. we hard coded a lot of defaults as we expect that part of the code to evolve significantly once we start dealing with supporting multiple istio versions (coming soon)

@peterj

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

Perfect! I'll go through the developer.md to set up everything properly and then work on the PR.

@ilackarms

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

if you require an ingress, you can install gloo to use as your istio ingress

however we absolutely intend to support istio's ingress! it will require some support on supergloo's api to configure ingress traffic

@ilackarms

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

awesome! feel free to ping me here or on slack with any questions

peterj added a commit to peterj/supergloo that referenced this issue Apr 27, 2019

Add Istio ingress/egress
This PR adds Istio ingress and egress options to the  CLI.

Closes solo-io#403

soloio-bulldozer bot added a commit that referenced this issue Apr 27, 2019

Add Istio ingress/egress (#404)
* Add Istio ingress/egress

This PR adds Istio ingress and egress options to the  CLI.

Closes #403
* Add changelog entry
* Re-create protos using 3.6.1 protoc.
* Move changelog to new folder, update deps and re-generate protos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.