Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When DBusActivatable (with some applicaitons) is set to "true", you can't run them from budgie-run-dialog #658

Closed
JannikHv opened this issue Oct 18, 2016 · 10 comments

Comments

@JannikHv
Copy link

JannikHv commented Oct 18, 2016

Operating System: Solus 1.2.0.5 + Arch Linux
Budgie version: Budgie 10.2.7

When answering some support tickets, I discovered a problem regarding budgie-run-dialog.

The problem is basically as described in the following:

A program like gedit or corebird have "DBusActivatable" set to true in their /usr/share/applications/ entry. If it's set to true, you can either not, or sometimes start it with budgie-run-dialog, but only if you try to open it multiple times in a row. When DBusActivatable is set to "false" or compeltely removed, it starts normally. It's a really weird behaviour...

Here is a video I made to demonstrate the problem. Sorry for the flickering and such...:

http://sendvid.com/qvxnywhi

@JannikHv JannikHv changed the title When DBusActivatabe is set to "true", you can't run them from budgie-run-dialog When DBusActivatabe (with some applicaitons) is set to "true", you can't run them from budgie-run-dialog Oct 18, 2016
@JannikHv JannikHv reopened this Oct 18, 2016
@JannikHv JannikHv changed the title When DBusActivatabe (with some applicaitons) is set to "true", you can't run them from budgie-run-dialog When DBusActivatable (with some applicaitons) is set to "true", you can't run them from budgie-run-dialog Oct 18, 2016
@ikeydoherty
Copy link
Member

Buh.

@ikeydoherty
Copy link
Member

So I thought I fixed this. Basically when dbus activatable is true the API just completely lies about when it is and isn't launched, so then we quit before the message gets across dbus...

@JannikHv
Copy link
Author

JannikHv commented Oct 18, 2016

It's just really, really weird. When dbus activatable is true and i open, for example gedit, 2 fast times in a row, it opens. But just after the second try when there wasn't much time (let's say about 5 Seconds) in between those 2 tries. It's really not a huge deal IMO, just really strange, especially because it just applies to specific types of applications.

Edit: Just for no misunderstanding, everything here is only related to budgie-run-dialog, not any other application launching. :)

@streambinder
Copy link

Actually, it's still happening (tested with gedit and many more apps).

ikeydoherty added a commit that referenced this issue Dec 12, 2016
We now monitor dbus names to see when the application actually comes
up, as opposed to niavely immediately quiting. This does mean some
quite nasty workarounds as we now have to monitor names on the bus
compared with the .desktop files.

For "normal" applications we obey the startup notification spec and
wait for them to fail or succeed, and quit then. It's also quite likely
that we'll have to add functionality to expire the rundialog after a
certain amount of time regardless of the call, in case dbus activation
failed (cuz it succeeds regardless) - and to ensure we show again when
we are app-activated.

This resolves issue #658.

Signed-off-by: Ikey Doherty <ikey@solus-project.com>
@ikeydoherty
Copy link
Member

^ Implemented, fixed, closed.

@m-delvalle
Copy link

@ikeydoherty after updating (including some budgie-related packages) I'm still having this issue 😢
Is this fix in the "stable" repo? Should this already be fixed on my install? Or do I have to wait until this particular fix gets published to end users?

@ikeydoherty
Copy link
Member

Needs releasing @m-delvalle - we're planning a 10.2.9 release. It's not really backportable I'm afraid, hence needing a new release

@m-delvalle
Copy link

@ikeydoherty np, just checking :)

@m-delvalle
Copy link

Update: just applied latest patches and it's working great now! thanks @ikeydoherty

@ikeydoherty
Copy link
Member

Woot! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants