Skip to content

Ignore notifications#335

Merged
ikeydoherty merged 2 commits intosolus-project:masterfrom
Manuel-Kehl:ignore-notifications
Feb 10, 2016
Merged

Ignore notifications#335
ikeydoherty merged 2 commits intosolus-project:masterfrom
Manuel-Kehl:ignore-notifications

Conversation

@Manuel-Kehl
Copy link
Contributor

My pull request addresses #301 by making it possible to add "spam apps" in terms of dconf settings.

Manuel Kehl added 2 commits February 10, 2016 01:40
At a later stage these could be exposed in the settings UI.
Settings values are taken into account when determining whether a
notification should be displayed in Raven and trigger the "unread
notifications state".
@JoshStrobl
Copy link
Contributor

I don't really think doing a complete blacklist to appeal to a single user's opinion on what shouldn't be in the notifications is the wrong way of implementing this. Personally, I use several of the music applications you're blacklisting in this PR and seeing notifications disappear for them would completely detract from the user experience.

Having a method to specify what applications should be ignored, graphically, is a preferred option instead.

@Manuel-Kehl
Copy link
Contributor Author

They are not disappearing completely. You will still see popups.
They simply won't trigger the "unread notification red clock icon" and won't flood your notification list in Raven.

@Manuel-Kehl
Copy link
Contributor Author

And of course a graphical front end to tweak the dconf entry would be a possible addition to this 😉

By the way: Lollypop and Gnome Music where already blocked before. I simply moved the definition of the "spam apps" list from a hardcoded array to a dconf setting.

@JoshStrobl
Copy link
Contributor

Right, I misunderstood this as blocking the notifications themselves. Continue on good sir :P

@ikeydoherty
Copy link
Member

Cheers!

ikeydoherty added a commit that referenced this pull request Feb 10, 2016
@ikeydoherty ikeydoherty merged commit ccb8289 into solus-project:master Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants