Add tools to deal with RPATH stupidity #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently many packages are building with RPATHing the libraries due to packages using libtool having an incorrect ld detection (cause proper detection was broken on other distros). The introduction of `LT_SYS_LIBRARY_PATH` overrides the detection to ensure it doesn't add RPATH for `/usr/lib64` thinking it won't be found. The norm appears to be searching for directories in `/etc/ld.so.conf` which doesn't exist in Solus. The second tool to combat RPATH issues is adding the `runpath` optimize key. `--enable-new-dtags` changes linking to use `DT_RUNPATH` instead of `DT_RPATH`, the difference being that `RUNPATH` dirs are searched *after* the default library locations. This will alleviate issues where `RPATH` is difficult to remove and not break expected library loading order. Signed-off-by: Peter O'Connor <peter@solus-project.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently many packages are building with RPATHing the libraries due to
packages using libtool having an incorrect ld detection (cause proper detection
was broken on other distros). The introduction of
LT_SYS_LIBRARY_PATHoverrides the detection to ensure it doesn't add RPATH for
/usr/lib64thinking it won't be found. The norm appears to be searching for directories
in
/etc/ld.so.confwhich doesn't exist in Solus.The second tool to combat RPATH issues is adding the
runpathoptimize key.--enable-new-dtagschanges linking to useDT_RUNPATHinstead ofDT_RPATH,the difference being that
RUNPATHdirs are searched after the defaultlibrary locations. This will alleviate issues where
RPATHis difficult toremove and not break expected library loading order.
Signed-off-by: Peter O'Connor peter@solus-project.com