Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Project name #61

Merged
merged 4 commits into from Jun 1, 2011

Conversation

Projects
None yet
2 participants
Contributor

Fluxx commented Jun 1, 2011

Hey Delano,

Here is the first stab at a pull request to add a project name to Rudy. Some notes:

  1. I created a -p project command line global, which you can use or you can define project 'name' in your defaults block in your Rudyfile.
  2. I changed all the instances of Rudy::DOMAIN to Rudy::DEFAULT_DOMAIN, as well as centralize all notion of what the domain is for the current Rudy project to Rudy::Huxtable.domain. This centralized domain takes in to account the project name (if specified).
  3. I changed the machine group name and metadata name to include the project name, if specified.
  4. As you requested, I made things backwards compatible so if you do not specify a project name, all the generated domains, groups and metadata names are the exact same as they are before this patch.

Please let me know if this all looks good and if you have any additional feedback. Once it does, I'll add some examples in examples/ and you can merge this pull request.

Collaborator

delano commented Jun 1, 2011

Ya, looks great so far. We'll need to use a different global parameter though. -p is used for position and -P for parallel (have you tried that btw?). We have two options: repurpose -P for project name or using -N which is not currently used. What do you think?

delano added a commit that referenced this pull request Jun 1, 2011

@delano delano merged commit 14a73eb into solutious:master Jun 1, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment