Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about destructor #477

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@rpavlik
Copy link
Contributor

commented Sep 10, 2019

It was griping in shared_ptr code about there being virtual functions without a virtual destructor and creating a non-final class. Easiest way to fix it was to make this a final class.

@whitequark whitequark merged commit a4c0022 into solvespace:master Sep 10, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@rpavlik rpavlik deleted the rpavlik:fix-destructor-warning branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.