Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better helical triangulation #489 and #550 fixed. #643

Merged
merged 1 commit into from Jul 11, 2020

Conversation

@phkahler
Copy link
Member

@phkahler phkahler commented Jul 7, 2020

…4 segments and forcing grid triangulation to use a minimum of 4x4 quads. This helps with issue #489. Also add a max_dt parameter for PWL creation and use that for helical edges.

@phkahler
Copy link
Member Author

@phkahler phkahler commented Jul 8, 2020

I want to hold off on this a bit more. Sorry for going too fast.

Loading

@whitequark
Copy link
Contributor

@whitequark whitequark commented Jul 8, 2020

Take all the time you need! There's no harm in having half-done pull requests (it may even help a bit by showing who works on what, and perhaps inspiring collaboration).

Loading

Resolve issue solvespace#489 helix has stairsteps.
Force helix axis line to 8 segments.
Grid triangulation to use a minimum of 4 segments for degree>1.
Adds twist dependence for grid triangulation with degree=1.
Added a max_dt parameter for PWL creation and use that for helical edges.
@phkahler
Copy link
Member Author

@phkahler phkahler commented Jul 9, 2020

@whitequark this seems to fix #550 as well. If you're OK with it I am.

Loading

@phkahler phkahler changed the title Better helical triangulation by forcing twisted curves to minimum of … Better helical triangulation - issue 489. Jul 10, 2020
@phkahler phkahler changed the title Better helical triangulation - issue 489. Better helical triangulation Jul 10, 2020
@phkahler phkahler changed the title Better helical triangulation Better helical triangulation Resolve issue #489 helix has stairsteps. Force helix axis line to 8 segments. Grid triangulation to use a minimum of 4 segments for degree>1. Adds twist dependence for grid triangulation with degree=1. Added a max_dt parameter for PWL creation and use that for helical edges. Jul 10, 2020
@phkahler phkahler changed the title Better helical triangulation Resolve issue #489 helix has stairsteps. Force helix axis line to 8 segments. Grid triangulation to use a minimum of 4 segments for degree>1. Adds twist dependence for grid triangulation with degree=1. Added a max_dt parameter for PWL creation and use that for helical edges. Better helical triangulation #489 and #550 fixed. Jul 10, 2020
@phkahler phkahler linked an issue that may be closed by this pull request Jul 11, 2020
@phkahler phkahler linked an issue that may be closed by this pull request Jul 11, 2020
@phkahler phkahler merged commit 9802b5d into solvespace:master Jul 11, 2020
2 of 3 checks passed
Loading
@phkahler phkahler deleted the better_helix branch Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants