Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue174 if selection for dragging is not in a previous group, us… #658

Closed
wants to merge 1 commit into from

Conversation

phkahler
Copy link
Member

@phkahler phkahler commented Jul 22, 2020

This needs some testing and it seems like the logic could maybe be simpler.

I figured the reason ChooseFromHoverToDrag() exists is to allow dragging entites from previous groups which doesn't happen with ChooseFromHoverToSelect(). If that's the case, we can just check if the drag selection found something from a previous group. If so use it, otherwise use the selection logic for dragging.

@phkahler
Copy link
Member Author

phkahler commented Jul 22, 2020

I can squash those if you want. Having drags fail because it tried to select something from group zero has been very annoying for me, hence the second commit.

@whitequark
Copy link
Contributor

whitequark commented Jul 23, 2020

Thanks for the fix! I'm going to need to look closer into it.

…e chooseFromHoverToSelect to select for dragging.
@phkahler
Copy link
Member Author

phkahler commented Aug 7, 2020

@whitequark can we merge this? It really does fix this problem, and it doesn't touch code for selection or hovering at all. All it does is prevent the new rules for dragging earlier groups from applying the same (first in the list) alternate logic to the current group. I'm still thinking about ways to solve the other dragging related issue.

@whitequark
Copy link
Contributor

whitequark commented Aug 7, 2020

Sorry, I still haven't found the time to look at this. I'm currently on vacation until the end of the next week, so I'll take a look around then. (Yes, I know I answered to some issues... old habits die slowly)

@phkahler
Copy link
Member Author

phkahler commented Aug 8, 2020

Closing as superseded by #672.

@phkahler phkahler closed this Aug 8, 2020
@phkahler phkahler deleted the issue174 branch Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants