New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required gems to run should be defined as runtime dependency #73

Merged
merged 1 commit into from Oct 14, 2016

Conversation

Projects
None yet
3 participants
@hokuma
Contributor

hokuma commented Oct 13, 2016

ruby-protocol-buffers and narray are used in library implementations.

ex.

Required gems to run should be defined as runtime dependency.

See: http://guides.rubygems.org/patterns/#declaring-dependencies

@chrhansen

This comment has been minimized.

Show comment
Hide comment
@chrhansen

chrhansen Oct 13, 2016

Collaborator

@hokuma that sounds plausible! I'm wondering if we should also remove our Gemfile.lock based in Yehuda's advice: http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

Collaborator

chrhansen commented Oct 13, 2016

@hokuma that sounds plausible! I'm wondering if we should also remove our Gemfile.lock based in Yehuda's advice: http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

@Arafatk

This comment has been minimized.

Show comment
Hide comment
@Arafatk

Arafatk Oct 14, 2016

Collaborator

@hokuma Thanks a lot for the contribution.
@chrhansen Yes, removing the Gemfile.lock seems right after reading the post and the few other answers on Stack overflow.

Collaborator

Arafatk commented Oct 14, 2016

@hokuma Thanks a lot for the contribution.
@chrhansen Yes, removing the Gemfile.lock seems right after reading the post and the few other answers on Stack overflow.

@Arafatk Arafatk merged commit 85d1e7f into somaticio:master Oct 14, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment