Nicer modal search #14

Merged
merged 2 commits into from Feb 28, 2014

Projects

None yet

2 participants

@elvanja
elvanja commented Feb 26, 2014
  • a few cosmetics refactoring
  • model search within modal forms now have the search glyphicon
  • also, placeholder have been added
@elvanja elvanja Nicer modal search:
* a few cosmetics refactoring
d9dbd95
@levity
Collaborator
levity commented Feb 27, 2014

One thing that would be helpful for me, when you're doing these kinds of
pull requests, is to attach a screenshot or two with an example of what
you've changed. Then I can form a quick opinion while checking my email,
even if I don't have the time to load your branch in my dev environment at
that moment.

On Wednesday, February 26, 2014, Vanja Radovanović notifications@github.com
wrote:

  • a few cosmetics refactoring
  • model search within modal forms now have the search glyphicon
  • also, placeholder have been added

You can merge this Pull Request by running

git pull https://github.com/elvanja/deckhand nicer_modal_search

Or view, comment on, or merge it at:

#14
Commit Summary

  • Nicer modal search:

File Changes

  • M app/assets/stylesheets/deckhand/index.css.scsshttps://github.com/somawater/deckhand/pull/14/files#diff-0(16)
  • M app/helpers/deckhand/templates_helper.rbhttps://github.com/somawater/deckhand/pull/14/files#diff-1(14)

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com/somawater/deckhand/pull/14
.

@elvanja
elvanja commented Feb 27, 2014

Right, will do :-)

Here is how it looks:
nicer_model_search
The campaign type now has the search icon, much like the same icon on search field on main screen. It also fades out on actual search being performed. The default placeholder text is shown, but can be overridden in form definition.

@levity levity merged commit 0ef2449 into somawater:master Feb 28, 2014
@elvanja elvanja deleted the elvanja:nicer_modal_search branch Feb 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment