This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Backport features from 7.x #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalmungSan
reviewed
Dec 4, 2018
project/build.properties
Outdated
| @@ -1 +1 @@ | |||
| sbt.version = 1.2.3 | |||
| sbt.version = 1.2.6 | |||
There was a problem hiding this comment.
We are already in sbt 1.2.7.
BalmungSan
reviewed
Dec 4, 2018
| @@ -42,6 +42,6 @@ private[scapegoat] final case class ScapegoatInspection( | |||
| defaultLevel: Level | |||
| ) | |||
|
|
|||
| private[scapegoat] object ScapegoatInspections { | |||
| object ScapegoatInspections { | |||
There was a problem hiding this comment.
Why made it public ?
With the work you did in #130 this can be _private to the scapegoat package, the same can go with the ScalastyleInspections object.
There was a problem hiding this comment.
Looks like I missed it after refactoring.
BalmungSan
reviewed
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Backporting features from 7.x - includes the recommended quality profile, updated generation of Scapegoat rules, version bumps and other minor tweaks.