Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Add a feature flag to the Scoverage Sensor #169

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

BalmungSan
Copy link
Contributor

Fixes #81

@mwz
Copy link
Member

mwz commented Mar 8, 2019

You're on fire - thanks for the PR, I'll review all of them later today.

@BalmungSan
Copy link
Contributor Author

BalmungSan commented Mar 8, 2019

"You're on fire".

Hahahaha 😎 thanks!

It has been a quite week, took the opportunity to help as much as possible now! - Since, next week I will start a new project, so I may be "out of game" for a while...

@mwz
Copy link
Member

mwz commented Mar 9, 2019

Looks good to me; can you think of any particular reason one might want to disable this sensor?

@mwz mwz merged commit 213a83e into sonar-scala:master Mar 9, 2019
@BalmungSan
Copy link
Contributor Author

"can you think of any particular reason one might want to disable this sensor?"

To be honest, no. In the sense that I also do not see any "reason" to disable any other sensor.
But, since we had been adding feature flags to all of them, it seems to me that we should be standard.

On the other hand, maybe if you need to add some hotfix really fast to production, but it reduces the coverage enough to make your CI build to fail, mauve disabling this sensor would be "good", since sonar will return the coverage of the previous scan...
Or maybe someone only want coverage information from jUnit instead of from Scoverage, who knows.

@BalmungSan BalmungSan deleted the scoverage-feature-flag branch March 9, 2019 23:07
@mwz
Copy link
Member

mwz commented Mar 10, 2019

Yeah, since we allow to disable other sensors it makes sense to be consistent and also allow to disable this one in case anyone wants to do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants