Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Fix for Scapegoat sensor not respecting module path for multi module projects. #96

Merged
merged 2 commits into from Aug 11, 2018

Conversation

mwz
Copy link
Member

@mwz mwz commented Aug 11, 2018

This PR fixes the Scapegoat sensor issue with multi-module projects where the report from the root module was used for each submodule. The fix was to resolve each report path relative to the working directory including the module directory when the sensor gets executed.

This fixes #92.

Hi @BalmungSan 馃憢, would you be able to review this PR?

@mwz mwz added this to In progress in sonar-scala via automation Aug 11, 2018
@@ -363,6 +379,62 @@ class ScapegoatSensorSpec
// validate the sensor behavior
sensorContext.allIssues shouldBe empty
}

it should "not report module issues" in {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that 'not' is out of place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for spotting this - fixed in 61a613a

@BalmungSan
Copy link
Contributor

Hi @mwz, Thanks a lot for fixing this, I have been incredibly busy, I'm sorry about that.

Everything looks fine to me (except for that test name).

Just one thing, maybe we should bump some dependencies in this PR too, like sbt to 1.2.1, sbt-assembly to 0.14.7, etc...

馃憤

@mwz
Copy link
Member Author

mwz commented Aug 11, 2018

Thanks for the review @BalmungSan. Since this is a hotfix, I'll just release it with the current versions and bump up dependencies and plugins in a separate PR.

@BalmungSan
Copy link
Contributor

Ok, go ahead.

@mwz mwz merged commit 797ce88 into master Aug 11, 2018
sonar-scala automation moved this from In progress to Done Aug 11, 2018
@mwz mwz deleted the scapegoat-multi-module-fix branch August 11, 2018 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
sonar-scala
  
Done
Development

Successfully merging this pull request may close these issues.

The new built-in scapegoat sensor cannot work.
2 participants