This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Fix for Scapegoat sensor not respecting module path for multi module projects. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalmungSan
reviewed
Aug 11, 2018
| @@ -363,6 +379,62 @@ class ScapegoatSensorSpec | |||
| // validate the sensor behavior | |||
| sensorContext.allIssues shouldBe empty | |||
| } | |||
|
|
|||
| it should "not report module issues" in { | |||
There was a problem hiding this comment.
I think that 'not' is out of place.
There was a problem hiding this comment.
thanks for spotting this - fixed in 61a613a
|
Hi @mwz, Thanks a lot for fixing this, I have been incredibly busy, I'm sorry about that. Everything looks fine to me (except for that test name). Just one thing, maybe we should bump some dependencies in this PR too, like sbt to 1.2.1, sbt-assembly to 0.14.7, etc... 👍 |
|
Thanks for the review @BalmungSan. Since this is a hotfix, I'll just release it with the current versions and bump up dependencies and plugins in a separate PR. |
|
Ok, go ahead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Scapegoat sensor issue with multi-module projects where the report from the root module was used for each submodule. The fix was to resolve each report path relative to the working directory including the module directory when the sensor gets executed.
This fixes #92.
Hi @BalmungSan 👋, would you be able to review this PR?