Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user guide to add how to handle permission issue #364

Closed

Conversation

qzhou1607-zz
Copy link
Contributor

Fix #325

@@ -57,6 +57,9 @@ the different pieces:
* [Connectors](#connectors)
* [Formatters](#formatters)

## Permission Issue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty line after this line

(see also: https://travis-ci.org/sonarwhal/sonar/jobs/250504088#L2417)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alrra Done. One question - some links can get quite long in markdown. Do we always have to use inline links? Referenced links seem to work better in those situations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some links can get quite long in markdown

Yes, that's why I said "were possible try to keep the length..."

Referenced links seem to work better in those situations.

Can you give an example on how that would look like? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alrra in the actual text part

...the recommended
solution is to [change npm's default directory][1] and then try again...

and then append the following at the end of the markdown

[1]:https://docs.npmjs.com/getting-started/fixing-npm-permissions#option-2-change-npms-default-directory-to-another-directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qzhou1607 If there are no problems when converting it to HTML, I'm ok with that.

@sonarwhal/contributors Other opinions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alrra checked in Hexo, looks okay. I've pushed up the changes.

@@ -57,6 +57,9 @@ the different pieces:
* [Connectors](#connectors)
* [Formatters](#formatters)

## Permission Issue
If you receive an `EACCES` error when installing `sonar`, the recommended solution is to [change npm's default directory](https://docs.npmjs.com/getting-started/fixing-npm-permissions#option-2-change-npms-default-directory-to-another-directory) and then try again. So far, one such permission issue has been reported when user tries to install `sonar` on [Windows Subsystem for Linux](https://msdn.microsoft.com/en-us/commandline/wsl/install_guide). Dependency `canvas-prebuilt` throws an `EACCES` error during the installation process, and this [issue](https://github.com/sonarwhal/sonar/issues/308) was resolved adopting the recommended solution. You can find detailed steps on how to change the npm default directory [here](https://docs.npmjs.com/getting-started/fixing-npm-permissions#option-2-change-npms-default-directory-to-another-directory).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split this line into multiple shorter lines, and were possible try to keep the length of the lines to under 80 characters.

`canvas-prebuilt` throws an `EACCES` error during the installation process,
and this [issue](https://github.com/sonarwhal/sonar/issues/308) was resolved
adopting the recommended solution. You can find detailed steps on how to change
the npm default directory [here](https://docs.npmjs.com/getting-started/fixing-npm-permissions#option-2-change-npms-default-directory-to-another-directory).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also capable of reproducing this with Mac.
I had node installed via the installer in their website but it looks like if you use Homebrew that problem doesn't show up (didn't had the time to test).
@alrra how did you installed node in your machine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alrra how did you installed node in your machine?

I use nvm both on macOS and Bash on Windows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe it is only something that happens if you use the official installer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@molant Added more information.

Copy link
Member

@molant molant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alrra anything else that needs to be done here or can we merge this PR?

@alrra alrra closed this in 37039dd Jul 10, 2017
alrra pushed a commit that referenced this pull request Jul 13, 2017
qzhou1607-zz added a commit to qzhou1607-zz/Sonar that referenced this pull request Jan 22, 2018
Fix sonarwhal/sonarwhal.com/webhintio#364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants