From 717e2adfc0f0bc62f6aa9177700a4ad0a0f71dc1 Mon Sep 17 00:00:00 2001 From: Vincent Langlet Date: Tue, 25 Aug 2020 21:54:05 +0200 Subject: [PATCH] Try --- src/Form/DataTransformer/ModelToIdPropertyTransformer.php | 3 ++- src/Form/DataTransformer/ModelsToArrayTransformer.php | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Form/DataTransformer/ModelToIdPropertyTransformer.php b/src/Form/DataTransformer/ModelToIdPropertyTransformer.php index 0c41095e71b..b4e9d1b9ab6 100644 --- a/src/Form/DataTransformer/ModelToIdPropertyTransformer.php +++ b/src/Form/DataTransformer/ModelToIdPropertyTransformer.php @@ -74,6 +74,7 @@ public function __construct( public function reverseTransform($value) { + /** @var ArrayCollection $collection */ $collection = new ArrayCollection(); if (empty($value)) { @@ -97,7 +98,7 @@ public function reverseTransform($value) continue; } - $collection[] = $this->modelManager->find($this->className, $id); + $collection->add($this->modelManager->find($this->className, $id)); } return $collection; diff --git a/src/Form/DataTransformer/ModelsToArrayTransformer.php b/src/Form/DataTransformer/ModelsToArrayTransformer.php index 2768a02f4e1..2a9f43f1544 100644 --- a/src/Form/DataTransformer/ModelsToArrayTransformer.php +++ b/src/Form/DataTransformer/ModelsToArrayTransformer.php @@ -147,13 +147,14 @@ public function reverseTransform($keys) throw new UnexpectedTypeException($keys, 'array'); } + /** @var ArrayCollection $collection */ $collection = new ArrayCollection(); $notFound = []; // optimize this into a SELECT WHERE IN query foreach ($keys as $key) { if ($model = $this->modelManager->find($this->class, $key)) { - $collection[] = $model; + $collection->add($model); } else { $notFound[] = $key; }