-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 5 - TODO list #6365
Comments
Problem with TranslatorInterface we can resolve based on idea from comment: namespace Symfony\Component\Translation;
if (!interface_exists('Symfony\Component\Translation\TranslatorInterface')) {
/**
* @deprecated since sonata-project/admin-bundle 3.x, to be removed in 4.0. Use \Symfony\Contracts\Translation\TranslatorInterface instead.
*/
class_alias('Symfony\Contracts\Translation\TranslatorInterface', 'Symfony\Component\Translation\TranslatorInterface');
} This alias will redirect ower |
Imho we should not do this. We don't own that interface so we should not alias it. This can cause all kind of weird issues with other bundles/libraries that do things based on the existence of the legacy interface etc. |
@VincentLanglet I create project based on admin and symfony 5. In issue description I add next problem to resolve which can not be done without huge BC-break on Sonata 3. I will add this issue to https://github.com/sonata-project/SonataAdminBundle/milestone/7 Update |
@greg0ire @wbloszyk @VincentLanglet so was there a decision if we want to support Symfony 5.1 on 3.x or not? I'm slightly confused by all the comments on different issues and PRs 😋 Also seeing that we keep adding support for symfony 5.1 components on 3.x like in #6363 Out of interest: For how long would 3.x still be maintained (features, bug fixes) after 4.0 was released? |
It will certainly be on 4.0 rather than 3.x to avoid multiple BC-break.
This was an easy change, with no BC-break and adding no complexity to the code.
Feature won't be added to 3.x as soon as we release 4.0 (except if does help our/the developer migration) |
I think we can support 3.x with some feature until we don't release whole Sonata4. Anyway we don't wanna do it for all PRs. |
Well, I'm not sure if it's easy or not, But I'd like to help, I'll try to get this one |
Hi @eerison Otherwise you can help with some other Sonata4 PR like this issue #6404 ; since the symfony 5 compatibility will be only released with Sonata 4. |
I think this can be closed tol |
I see a lot of things are happening on 3.x and master 💪 😊 Is there a todo list to see whats missing for releasing 4.0? https://github.com/sonata-project/SonataAdminBundle/milestone/6 maybe ? I'm really looking forward to a release with Symfony 5 support and would like to help if possible |
Indeed, I try to keep the milestone up to date. The only missing issues are
|
This is TODO list require to add support for Symfony 5.
Target branch: master (Sonata 4)
Reason: To much huge BC-break in Sonata 3 (list below).
Add support for Symfony 5.1 bundles (bundles related to Symfony version):
Changes in self code:
Symfony\Bundle\FrameworkBundle\Controller\Controller
Symfony\Bundle\FrameworkBundle\Controller\ControllerTrait
Symfony\Component\OptionsResolver\OptionsResolver::getExtendedTypes(): iterable;
Symfony\Component\Translation\TranslatorInterface
Library:
The text was updated successfully, but these errors were encountered: