Symfony 5 - TODO list

[wbloszyk]

This is TODO list require to add support for Symfony 5.

Target branch: master (Sonata 4)
Reason: To much huge BC-break in Sonata 3 (list below).

Add support for Symfony 5.1 bundles (bundles related to Symfony version):

• symfony/asset
• symfony/config
• symfony/console
• symfony/dependency-injection
• symfony/doctrine-bridge
• symfony/event-dispatcher
• symfony/form
• symfony/framework-bundle
• symfony/http-kernel
• symfony/routing
• symfony/security-bundle
• symfony/security-core
• symfony/security-csrf
• symfony/translation
• symfony/twig-bridge
• symfony/twig-bundle

Changes in self code:

• remove using Symfony\Bundle\FrameworkBundle\Controller\Controller
• remove using Symfony\Bundle\FrameworkBundle\Controller\ControllerTrait
• add return type hint Symfony\Component\OptionsResolver\OptionsResolver::getExtendedTypes(): iterable;
• remove using Symfony\Component\Translation\TranslatorInterface

Library:

• https://github.com/symfony/symfony/blob/master/UPGRADE-5.0.md
• https://github.com/symfony/symfony/blob/master/UPGRADE-5.1.md
• Symfony 5 compatibility #5788
• Symfony 5.0 compatibility #6093
• Add Symfony 5 compatibility #6263

[wbloszyk]

Problem with TranslatorInterface we can resolve based on idea from comment:
#6342 (comment)

namespace Symfony\Component\Translation;

if (!interface_exists('Symfony\Component\Translation\TranslatorInterface')) {
    /**
     * @deprecated since sonata-project/admin-bundle 3.x, to be removed in 4.0. Use \Symfony\Contracts\Translation\TranslatorInterface instead.
     */
    class_alias('Symfony\Contracts\Translation\TranslatorInterface', 'Symfony\Component\Translation\TranslatorInterface');
}

This alias will redirect ower setTranslator(ComponentTranslatorInterface $translator) to setTranslator(ContractsTranslatorInterface $translator) when user upgrade Symfony to 5. This will be BC.

[wbloszyk]

@sonata-project/contributors @dmaicher @jaikdean

• WDYT? Can we add it in Sonata3?

If I miss any problem, feel free to add notes about it.

[dmaicher]

Problem with TranslatorInterface we can resolve based on idea from comment:
#6342 (comment)

namespace Symfony\Component\Translation;

if (!interface_exists('Symfony\Component\Translation\TranslatorInterface')) {
    /**
     * @deprecated since sonata-project/admin-bundle 3.x, to be removed in 4.0. Use \Symfony\Contracts\Translation\TranslatorInterface instead.
     */
    class_alias('Symfony\Contracts\Translation\TranslatorInterface', 'Symfony\Component\Translation\TranslatorInterface');
}

This alias will redirect ower setTranslator(ComponentTranslatorInterface $translator) to setTranslator(ContractsTranslatorInterface $translator) when user upgrade Symfony to 5. This will be BC.

Imho we should not do this. We don't own that interface so we should not alias it. This can cause all kind of weird issues with other bundles/libraries that do things based on the existence of the legacy interface etc.

[VincentLanglet]

@sonata-project/contributors @dmaicher @jaikdean

• WDYT? Can we add it in Sonata3?

If it was easy, and didn't require BC-break, it would be ok. But it's not.
As explained in another discussion, I think we should focus on 4.0 to release it this year with the Symfony 5 support.

[wbloszyk]

@VincentLanglet I create project based on admin and symfony 5. In issue description I add next problem to resolve which can not be done without huge BC-break on Sonata 3. I will add this issue to https://github.com/sonata-project/SonataAdminBundle/milestone/7

Update
My bad, we can do it in Sonata 4 as minor release 😄

[dmaicher]

@greg0ire @wbloszyk @VincentLanglet so was there a decision if we want to support Symfony 5.1 on 3.x or not? I'm slightly confused by all the comments on different issues and PRs 😋

Also seeing that we keep adding support for symfony 5.1 components on 3.x like in #6363

Out of interest: For how long would 3.x still be maintained (features, bug fixes) after 4.0 was released?

[VincentLanglet]

@greg0ire @wbloszyk @VincentLanglet so was there a decision if we want to support Symfony 5.1 on 3.x or not? I'm slightly confused by all the comments on different issues and PRs 😋

It will certainly be on 4.0 rather than 3.x to avoid multiple BC-break.
If you want to help us, we take it !

Also seeing that we keep adding support for symfony 5.1 components on 3.x like in #6363

This was an easy change, with no BC-break and adding no complexity to the code.

Out of interest: For how long would 3.x still be maintained (features, bug fixes) after 4.0 was released?

Feature won't be added to 3.x as soon as we release 4.0 (except if does help our/the developer migration)
Bug could be backport to 3.x during some time, since the 4.0 introduce big changes. But keep in mind generally don't support multiple versions at the same time.

[wbloszyk]

Out of interest: For how long would 3.x still be maintained (features, bug fixes) after 4.0 was released?

Feature won't be added to 3.x as soon as we release 4.0 (except if does help our/the developer migration)
Bug could be backport to 3.x during some time, since the 4.0 introduce big changes. But keep in mind generally don't support multiple versions at the same time.

I think we can support 3.x with some feature until we don't release whole Sonata4. Anyway we don't wanna do it for all PRs.

[eerison]

Well, I'm not sure if it's easy or not, But I'd like to help, I'll try to get this one symfony/console, But if you have some other suggestion to start could be good, because I'll see how it works :)

[VincentLanglet]

Well, I'm not sure if it's easy or not, But I'd like to help, I'll try to get this one symfony/console, But if you have some other suggestion to start could be good, because I'll see how it works :)

Hi @eerison
I think that everything will be solved by this PR: #6476
If you can help on it, it's perfect.

Otherwise you can help with some other Sonata4 PR like this issue #6404 ; since the symfony 5 compatibility will be only released with Sonata 4.

[jordisala1991]

I think this can be closed tol

[dmaicher]

I see a lot of things are happening on 3.x and master 💪 😊

Is there a todo list to see whats missing for releasing 4.0?

https://github.com/sonata-project/SonataAdminBundle/milestone/6 maybe ?

I'm really looking forward to a release with Symfony 5 support and would like to help if possible

[VincentLanglet]

Is there a todo list to see whats missing for releasing 4.0?

https://github.com/sonata-project/SonataAdminBundle/milestone/6 maybe ?

Indeed, I try to keep the milestone up to date.
There is a lot of PR opened currently (and ready) but we're missing from maintainers time to review all of these (It's not the best period for github activity ^^). You may help with reviews/approval to catch errors faster.

The only missing issues are

• Renaming Pager::getNbResults method #6710 (Need discussion)
• Trigger warning / error when FormMapper::ifEnd is missing #5806 (follow our will to clean the API)
• Investigate default behavior of fieldOptions ['required' => false] #6272 (follow our will to clean the API)
• ProxyQueryInterface::execute and PagerInterface::getResult methods are too much doctrine-related. #6260 (Need discussion)
  We can't consider that it's a blocking point for 4.0 but it would be nice to have them.